We're updating the issue view to help you get more done. 

NullPointerException thrown on commit hook execution after update of Stash and Notifyr plugin

Description

After updating Notifyr to 2.1.0 and Stash to 3.1.1, the commit hooks are throwing NPE, as shown below. This causes the system to not send emails on commits.

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 2014-07-05 03:35:12,752 WARN [AtlassianEvent::pool-2-thread-1] droy 215x645x0 jjco4b [IP REMOVED] SSH - git-receive-pack '/fd/fuego-docs.git' c.a.s.i.h.r.AsyncPostReceiveRepositoryHookAdapter Push Event Hook nl.stefankohler.stash.notifyr.hook.SendNotificationHook failed. java.lang.NullPointerException: null at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:187) ~[guava-11.0.2-atlassian-01.jar:na] at com.google.common.collect.SingletonImmutableList.<init>(SingletonImmutableList.java:41) ~[guava-11.0.2-atlassian-01.jar:na] at com.google.common.collect.ImmutableList.of(ImmutableList.java:80) ~[guava-11.0.2-atlassian-01.jar:na] at nl.stefankohler.stash.notifyr.email.EmailNotificationServiceImpl.sendCommitNotification(EmailNotificationServiceImpl.java:88) ~[na:na] at nl.stefankohler.stash.notifyr.email.EmailNotificationServiceImpl.sendHookNotification(EmailNotificationServiceImpl.java:52) ~[na:na] at nl.stefankohler.stash.notifyr.hook.SendNotificationHook.postReceive(SendNotificationHook.java:45) ~[na:na] at com.atlassian.stash.internal.hook.repository.AsyncPostReceiveRepositoryHookAdapter$1.visit(AsyncPostReceiveRepositoryHookAdapter.java:49) [stash-service-impl-3.1.1.jar:na] at com.atlassian.stash.internal.hook.repository.AsyncPostReceiveRepositoryHookAdapter$1.visit(AsyncPostReceiveRepositoryHookAdapter.java:45) [stash-service-impl-3.1.1.jar:na] at com.atlassian.stash.internal.hook.repository.DefaultRepositoryHookService$8.doInTransaction(DefaultRepositoryHookService.java:411) [stash-service-impl-3.1.1.jar:na] at com.atlassian.stash.internal.hook.repository.DefaultRepositoryHookService$8.doInTransaction(DefaultRepositoryHookService.java:405) [stash-service-impl-3.1.1.jar:na] at org.springframework.transaction.support.TransactionTemplate.execute(TransactionTemplate.java:133) [spring-tx-4.0.5.RELEASE.jar:4.0.5.RELEASE] at com.atlassian.stash.internal.hook.repository.DefaultRepositoryHookService.visitEnabledHooks(DefaultRepositoryHookService.java:405) [stash-service-impl-3.1.1.jar:na] at com.atlassian.stash.internal.hook.repository.AsyncPostReceiveRepositoryHookAdapter.postReceive(AsyncPostReceiveRepositoryHookAdapter.java:45) [stash-service-impl-3.1.1.jar:na] at com.atlassian.stash.internal.hook.repository.AsyncPostReceiveRepositoryHookAdapter.onRefsChangedEvent(AsyncPostReceiveRepositoryHookAdapter.java:40) [stash-service-impl-3.1.1.jar:na] at com.atlassian.event.internal.SingleParameterMethodListenerInvoker.invoke(SingleParameterMethodListenerInvoker.java:36) [atlassian-event-2.3.5.jar:na] at com.atlassian.stash.internal.event.AsyncBatchingInvokersTransformer$AsyncInvokerBatch.invoke(AsyncBatchingInvokersTransformer.java:100) [stash-platform-3.1.1.jar:na] at com.atlassian.event.internal.AsynchronousAbleEventDispatcher$1$1.run(AsynchronousAbleEventDispatcher.java:48) [atlassian-event-2.3.5.jar:na] at com.atlassian.sal.core.executor.ThreadLocalDelegateRunnable.run(ThreadLocalDelegateRunnable.java:38) [sal-core-2.11.0.jar:na] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) [na:1.7.0_45] at java.lang.Thread.run(Thread.java:744) [na:1.7.0_45] ... 31 frames trimmed 2014-07-05 03:35:12,791 DEBUG [Indexer:thread-1] droy 182x322x0 1md11x1 [IP REMOVED] SSH - git-receive-pack '/fd/fuego-docs.git' com.atlassian.stash.scm.BaseCommand Executed /usr/bin/gi

Environment

Stash 3.1.1

Status

Assignee

Daniel Roy

Reporter

Daniel Roy

Labels

None

SEN

None

Bitbucket version

None

Fix versions

Affects versions

2.1.0

Priority

Critical